+tck explains createElement in more useful terms #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -243,11 +243,17 @@ Subscriber rules Verification is split up into two files (styles) of tests. | |||
|
|
|||
| The Blackbox Verification tests do not require the implementation under test to be modified at all, yet they are *not* able to verify most rules. In Whitebox Verification, more control over `request()` calls etc. is required in order to validate rules more precisely. | |||
|
|
|||
| It is highly recommended to implement the `SubscriberBlackboxVerification<T>` instead of the blackbox one even if it is more troublesome to do so, as it can test far more corner cases in implementations that would otherwise be left untested (if only blackbox tests would be used). | |||
There was a problem hiding this comment.
Seems odd to recommend the blackbox instead of... the blackbox...
There was a problem hiding this comment.
I suspect the correct word is "work" rather than "troublesome".
There was a problem hiding this comment.
- thanks!
- "if it is more troublesome to do so" sounds valid to me, but I'll reword/simplify :)
|
Thanks for the review, pushed fixups. // @viktorklang |
|
// Note to self, editing anything that needs attention in the github edit+pr window is a bad idea ;) |
|
LGTM! @reactive-streams/contributors This is a TCK documentation update addressing a question from @purplefox, merging this in 24h unless someone complains (so we can get RC4 out tomorrow). |
|
@reactive-streams/contributors Merging without objection |
viktorklang
added a commit
that referenced
this pull request
Mar 27, 2015
+tck explains createElement in more useful terms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #231